[PATCH][CilkPlus] Fix PR69363

Ilya Verbin iverbin@gmail.com
Wed Feb 17 15:08:00 GMT 2016


On Wed, Feb 17, 2016 at 15:46:00 +0100, Jakub Jelinek wrote:
> On Wed, Feb 17, 2016 at 05:32:58PM +0300, Ilya Verbin wrote:
> > +		  && !SCALAR_FLOAT_TYPE_P (TREE_TYPE (t))
> > +		  && TREE_CODE (TREE_TYPE (t)) != POINTER_TYPE)
> > +		{
> > +		  error_at (OMP_CLAUSE_LOCATION (c),
> > +			    "linear clause applied to non-integral, "
> > +			    "non-floating, non-pointer variable with type %qT",
> > +			    TREE_TYPE (t));
> > +		  remove = true;
> > +		  break;
> > +		}
> > +	    }
> > +	  else
> > +	    {
> > +	      if (!INTEGRAL_TYPE_P (TREE_TYPE (t))
> > +		  && TREE_CODE (TREE_TYPE (t)) != POINTER_TYPE)
> > +		{
> > +		  error_at (OMP_CLAUSE_LOCATION (c),
> > +			    "linear clause applied to non-integral non-pointer "
> 
> This line is too long.  But you could have just done

My editor shows exactly 80 chars.

> > --- a/gcc/cp/semantics.c
> > +++ b/gcc/cp/semantics.c
> 
> > +		      error ("linear clause applied to non-integral, "
> > +			     "non-floating, non-pointer variable with %qT type",
> 
> Again too long line, that needs to be wrapped more.

OK, here is 81.

> > +			     TREE_TYPE (t));
> > +		      remove = true;
> > +		      break;
> > +		    }
> > +		}
> > +	      else
> > +		{
> > +		  if (!INTEGRAL_TYPE_P (type)
> > +		      && TREE_CODE (type) != POINTER_TYPE)
> > +		    {
> > +		      error ("linear clause applied to non-integral non-pointer "
> > +			     "variable with %qT type", TREE_TYPE (t));
> > +		      remove = true;
> > +		      break;
> 
> And this can be done like I've hinted above.

OK, here is 81.

  -- Ilya



More information about the Gcc-patches mailing list