[PATCH][ARM] PR target/69161: Don't ignore mode when matching comparison operator in cstore-like patterns

[Kyrill Tkachov]

Hi Nick,

On 17/02/16 13:13, Nick Clifton wrote:
> Hi Kyrill,
>
>> Ok for trunk?
>>
>> 2016-01-29  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
>>
>>      PR target/69161
>>      * config/arm/predicates.md (arm_comparison_operator_mode):
>>      New predicate.
>>      * config/arm/arm.md (*mov_scc): Use arm_comparison_operator_mode
>>      instead of arm_comparison_operator.
>>      (*mov_negscc): Likewise.
>>      (*mov_notscc): Likewise.
>>      * config/arm/thumb2.md (*thumb2_mov_scc): Likewise.
>>      (*thumb2_mov_negscc): Likewise.
>>      (*thumb2_mov_negscc_strict_it): Likewise.
>>      (*thumb2_mov_notscc): Likewise.
>>      (*thumb2_mov_notscc_strict_it): Likewise.
> Approved - please apply - but ...
>

Thanks!

>> diff --git a/gcc/config/arm/predicates.md b/gcc/config/arm/predicates.md
>> index c66c31d5c6047aa7decfe7e95d111d5fbf6fb52e..b8f09ab6b109f80abe2df08a8b7f954f521ec1bf 100644
>> --- a/gcc/config/arm/predicates.md
>> +++ b/gcc/config/arm/predicates.md
>> @@ -341,6 +341,11 @@ (define_special_predicate "arm_comparison_operator"
>>     (and (match_operand 0 "expandable_comparison_operator")
>>          (match_test "maybe_get_arm_condition_code (op) != ARM_NV")))
>>   
>> +;; Likewise, but don't ignore the mode.
>> +(define_predicate "arm_comparison_operator_mode"
> Please could you extend the comment here to reference the PR.  That way
> anyone reading this code who wonders why we need to have two versions of
> the same predicate will be able understand what is happening.

Ok, here's what I committed with r233495.

Kyrill

> Cheers
>    Nick
>

-------------- next part --------------
A non-text attachment was scrubbed...
Name: arm-comp-mode.patch
Type: text/x-patch
Size: 4330 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20160217/6e27b4b8/attachment.bin>