[PING][PATCH, PR67709 ] Don't call call_cgraph_insertion_hooks in simd_clone_create

[Tom de Vries]

On 16/02/16 17:54, Jakub Jelinek wrote:
> On Tue, Feb 16, 2016 at 05:52:55PM +0100, Tom de Vries wrote:
>> Committed both patches to 4.9 and 5 branches.
>>
>> In order to run testsuite/libgomp.fortran/declare-simd-4.f90 with the 4.9
>> branch build, I needed in addition:
>> - r212268
>>    https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=212268
>>    https://gcc.gnu.org/ml/gcc-patches/2014-07/msg00218.html
>> - r219606
>>    https://gcc.gnu.org/viewcvs/gcc?view=revision&revision=219606
>>    https://gcc.gnu.org/ml/gcc-patches/2015-01/msg00615.html
>>
>> Should these also be back-ported to 4.9 branch (and in case of r219606, also
>> follow-up fix r219722,
>> https://gcc.gnu.org/viewcvs?rev=219722&root=gcc&view=rev , fix for
>> https://gcc.gnu.org/bugzilla/show_bug.cgi?id=64605 )?
>
> IMHO just don't backport that test, test it by hand only.
>

I've already committed the testcase, and without these two patches the 
test shows up as unsupported, so I'll leave it at that.

As for the lto bit (r219606) I can see your point, it's the only libgomp 
test that uses lto.

But there are 16 test cases which are currently unsupported in the 4.9 
branch, and would be supported with the fortran patch (r212268):
...
libgomp.fortran/allocatable11.f90
libgomp.fortran/allocatable2.f90
libgomp.fortran/allocatable8.f90
libgomp.fortran/appendix-a/a.22.7.f90
libgomp.fortran/appendix-a/a.22.8.f90
libgomp.fortran/crayptr2.f90
libgomp.fortran/declare-simd-1.f90
libgomp.fortran/declare-simd-2.f90
libgomp.fortran/omp_parse3.f90
libgomp.fortran/pointer2.f90
libgomp.fortran/pr25162.f
libgomp.fortran/pr32550.f90
libgomp.fortran/threadprivate1.f90
libgomp.fortran/threadprivate2.f90
libgomp.fortran/threadprivate3.f90
libgomp.fortran/threadprivate4.f90
...
Perhaps that makes it worthwhile to back-port the patch.

Thanks,
- Tom