[PATCH] PR driver/69265: improved suggestions for various misspelled options

Jeff Law law@redhat.com
Fri Feb 12 08:13:00 GMT 2016


On 02/11/2016 08:43 AM, David Malcolm wrote:
> On Thu, 2016-02-11 at 10:16 +0100, Richard Biener wrote:
>> On Wed, Feb 10, 2016 at 5:25 PM, Bernd Schmidt <bschmidt@redhat.com>
>> wrote:
>>> On 02/09/2016 09:44 PM, David Malcolm wrote:
>>>>
>>>> This is a bug in a new feature, so it isn't a regression as such,
>>>> but
>>>> it's fairly visible, and I believe the fix is relatively low-risk
>>>> (error-handling of typos of command-line options).
>>>>
>>>> This also now covers PR driver/69453 (and its duplicate PR
>>>> driver/69642), so people *are* running into this.
>>>
>>>
>>> I think the patch looks reasonable (I expect it needs slight
>>> adjustment
>>> after an earlier sanitizer options change). Whether it's OK or not
>>> at this
>>> stage is something I think I'll want to ask a RM. My inclination
>>> would be
>>> yes.
>>
>> Yes.
>
> Thanks.  Were you approving the idea of fixing this bug in stage 4, or
> approving the patch itself?   Note that the patch needed some changes
> to apply against trunk; the latest version is at:
> https://gcc.gnu.org/ml/gcc-patches/2016-02/msg00724.html
I think the combination of Bernd's comments and Richi's "Yes" is enough 
to consider this approved for the trunk.

jeff



More information about the Gcc-patches mailing list