[PATCH] PR driver/69265: improved suggestions for various misspelled options
Bernd Schmidt
bschmidt@redhat.com
Wed Feb 10 16:25:00 GMT 2016
On 02/09/2016 09:44 PM, David Malcolm wrote:
> This is a bug in a new feature, so it isn't a regression as such, but
> it's fairly visible, and I believe the fix is relatively low-risk
> (error-handling of typos of command-line options).
>
> This also now covers PR driver/69453 (and its duplicate PR
> driver/69642), so people *are* running into this.
I think the patch looks reasonable (I expect it needs slight adjustment
after an earlier sanitizer options change). Whether it's OK or not at
this stage is something I think I'll want to ask a RM. My inclination
would be yes.
A small improvement might be calculating the candidates array only once
when making the first suggestion and not freeing it. BTW, I've also run
into a case of an unhelpful suggestion:
./cc1 ~/hw.c -fno-if-convert
cc1: error: unrecognized command line option â-fno-if-convertâ
which should instead suggest fno-if-conversion.
Bernd
More information about the Gcc-patches
mailing list