[PATCH] combine: distribute_notes again (PR69567, PR64682)

Segher Boessenkool segher@kernel.crashing.org
Sun Feb 7 00:51:00 GMT 2016


On Sat, Feb 06, 2016 at 09:54:25AM -0800, H.J. Lu wrote:
> On Thu, Feb 4, 2016 at 3:28 PM, Segher Boessenkool
> <segher@kernel.crashing.org> wrote:
> > On Tue, Feb 02, 2016 at 11:32:08AM +0000, Segher Boessenkool wrote:
> >> As it happens the patch I did over a year ago for PR64682 isn't quite
> >> correct.  This is PR69567.  This fixes it.
> >>
> >> Tested on the separate testcases; also did bootstrap + testsuite on
> >> powerpc64-linux and x86_64-linux.  I'll commit this tomorrow or so if
> >> no one sees something wrong with it.
> >>
> >>
> >> 2016-02-02  Segher Boessenkool  <segher@kernel.crashing.org>
> >>
> >>       PR rtl-optimization/64682
> >>       PR rtl-optimization/69567
> >>       * combine.c (distribute_notes) <REG_DEAD>: Place the death note
> >>       before I2 only if the register is both used and set in I2.
> >
> > Committed to mainline and 5 now.
> >
> 
> This caused:
> 
> FAIL: gcc.c-torture/execute/pr64682.c   -O2  execution test
> FAIL: gcc.c-torture/execute/pr64682.c   -O2 -flto
> -fno-use-linker-plugin -flto-partition=none  execution test
> FAIL: gcc.c-torture/execute/pr64682.c   -O2 -flto -fuse-linker-plugin
> -fno-fat-lto-objects  execution test
> FAIL: gcc.c-torture/execute/pr64682.c   -O3 -fomit-frame-pointer  execution test
> FAIL: gcc.c-torture/execute/pr64682.c   -O3 -fomit-frame-pointer
> -funroll-all-loops -finline-functions  execution test
> FAIL: gcc.c-torture/execute/pr64682.c   -O3 -fomit-frame-pointer
> -funroll-loops  execution test
> FAIL: gcc.c-torture/execute/pr64682.c   -O3 -g  execution test
> 
> on x86 on GCC 5 branch.  Trunk is OK.  Did you miss a backport from
> trunk?

I tested it on x86_64-linux.  What does "x86" mean, exactly?

Note -O2 and -O3 do not exhibit the fail condition on trunk on the 64682
testcase (but -O1 does).


Segher



More information about the Gcc-patches mailing list