[PATCH] [AArch64] Implement popcount pattern

Hurugalawadi, Naveen Naveen.Hurugalawadi@cavium.com
Tue Dec 13 11:51:00 GMT 2016


Hi Kyrill,

Thanks for reviewing the patch and your useful comments.

>> looks good to me if it has gone through the normal required
>> bootstrap and testing, but I can't approve.

Bootstrapped and Regression Tested on aarch64-thunderx-linux.

>> The rest of the MD file uses the term AdvSIMD. Also, the instrurction
>> is CNT rather than "pop count".

Done.

>> __builtin_popcount takes an unsigned int, so this should be 
>> scanning for absence of popcountsi2 instead?

Done.

Please find attached the modified patch as per review comments
and let me know if its okay for Stage-1 or current branch.

Thanks,
Naveen
-------------- next part --------------
A non-text attachment was scrubbed...
Name: popcount-1.patch
Type: text/x-diff
Size: 1796 bytes
Desc: popcount-1.patch
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20161213/17d1ce11/attachment.bin>


More information about the Gcc-patches mailing list