[PATCH] Fix PR78027

Jeff Law law@redhat.com
Mon Dec 12 16:39:00 GMT 2016


On 12/12/2016 09:37 AM, Jakub Jelinek wrote:
> On Mon, Dec 12, 2016 at 09:29:44AM -0700, Jeff Law wrote:
>>>>> 2016-12-08  Cesar Philippidis  <cesar@codesourcery.com>
>>>>>
>>>>>    PR fortran/78027
>>>>>
>>>>>    gcc/
>>>>>    * ipa-icf.c (sem_function::parse): Don't process functions with
>>>>>    oacc decl attributes, as they may be OpenACC routines.
>>>>>
>>>>>    gcc/testsuite/
>>>>>    * c-c++-common/goacc/acc-icf.c: New test.
>>>>>    * gfortran.dg/goacc/pr78027.f90: New test.
>>>> This follows the same approach as we do for openmp.  This is fine for
>>>> the trunk.
>>>
>>> Is this also OK for gcc-6?
>> Your call -- I don't think folks are really using OpenACC much in gcc-6, but
>> if you think it's worth the time, go ahead.
>
> As Alex noted, the patch looks wrong, there should be "omp declare target"
> attribute, which isn't specific to OpenMP only, but covers all the
> offloading fns.  I have on my todo list to look at it.
I thought the final resolution of that thread was a misunderstanding 
from Alex as to how this stuff worked.  If I'm wrong, then obviously we 
shouldn't apply the patch to the trunk or branch.

jeff



More information about the Gcc-patches mailing list