[PATCH] Fixups for Martin's gimple-ssa-sprintf.c patch

Martin Sebor msebor@gmail.com
Wed Aug 31 16:23:00 GMT 2016


On 08/25/2016 10:30 AM, Martin Sebor wrote:
> On 08/25/2016 10:23 AM, David Malcolm wrote:
>> Martin: here are the fixups for your patch I needed to apply to make
>> it work with mine.  I couldn't actually get any of your existing test
>> cases to emit locations within the string literals, due to them all
>> being embedded in macro expansions (possibly relating to PR c/77328),
>> so I added a simple testcase using -fdiagnostics-show-caret, which
>> does successfully show a range within the string.
>>
>> Posting in the hope that it's helpful; I haven't attempted a bootstrap
>> with it.

I've tried the patch but the changes don't compile because
substring_loc is not declared.  I see the class defined in
c-family/c-common.h which I can't include here in the middle
end.  Am I missing some another patch?

Thanks
Martin



More information about the Gcc-patches mailing list