[PATCH 1/4][PR 71931] Fix libatomic tests

Szabolcs Nagy szabolcs.nagy@arm.com
Thu Aug 25 08:45:00 GMT 2016


On 24/08/16 23:08, Joseph Myers wrote:
> On Wed, 24 Aug 2016, Szabolcs Nagy wrote:
> 
>> diff --git a/libatomic/testsuite/lib/libatomic.exp b/libatomic/testsuite/lib/libatomic.exp
>> index cafab54..e374c64 100644
>> --- a/libatomic/testsuite/lib/libatomic.exp
>> +++ b/libatomic/testsuite/lib/libatomic.exp
>> @@ -47,6 +47,8 @@ load_gcc_lib timeout.exp
>>  load_gcc_lib timeout-dg.exp
>>  load_gcc_lib fortran-modules.exp
>>  
>> +load_file libatomic-test-support.exp
> 
> This approach looks like it would break installed testing.  Such 
> information from the build tree should only be loaded when 
> TESTING_IN_BUILD_TREE is defined.
> 

i followed the solution in libgomp for passing
offloading parameters.

it seems TESTING_IN_BUILD_TREE is not set in
target lib site.exp so that should be wired
up somehow.

i'm not sure how installed testing works, if
it does not use the build tree site.exp, then
i can try to add BUILD_CC to site.exp.
(there is an EXTRA_DEJAGNU_SITE_CONFIG hook)



More information about the Gcc-patches mailing list