[Patch, testsuite] Skip tests that expect 4 byte alignment for avr
Jeff Law
law@redhat.com
Thu Aug 18 20:02:00 GMT 2016
On 08/16/2016 11:55 PM, Senthil Kumar Selvaraj wrote:
>
> Jeff Law writes:
>
>> On 08/11/2016 01:40 AM, Senthil Kumar Selvaraj wrote:
>>> Hi,
>>>
>>> The below patch adds the AVR target to the list of targets that don't
>>> have natural_alignment_32. It also skips ipa/propalign-*.c
>>> tests (which expect 4 byte alignment), if both
>>> natural_alignment_32 and natural_alignment_64 are false.
>>>
>>> Is this the right way to fix this? Ok to commit?
>>>
>>> Regards
>>> Senthil
>>>
>>> gcc/testsuite/ChangeLog:
>>>
>>> 2016-08-11 Senthil Kumar Selvaraj <senthil_kumar.selvaraj@atmel.com>
>>>
>>> * gcc.dg/ipa/propalign-1.c: Skip for targets with !natural_alignment_32
>>> and !natural_alignment_64.
>>> * gcc.dg/ipa/propalign-2.c: Likewise.
>>> * gcc.dg/ipa/propalign-3.c: Likewise.
>>> * gcc.dg/ipa/propalign-4.c: Likewise.
>>> * gcc.dg/ipa/propalign-5.c: Likewise.
>>> * lib/target-supports.exp
>>> (check_effective_target_natural_alignment_32): Add avr-*-*.
>> Do you need to add an avr case to
>> check_effective_target_natural_alignment_64 as well?
>
> The 64 bit version is written to return true only for lp64 and spu-*-*,
> so I didn't have to do anything there.
>>
>> Have you tested this on anything other than avr?
>>
>
> Yes, x86_64-pc-linux passes these tests, like it did before my patch.
OK for the trunk. Please install.
Thanks,
jeff
More information about the Gcc-patches
mailing list