Go patch committed: Implement go:noinline and go:nosplit directives

Ian Lance Taylor iant@golang.org
Wed Aug 10 00:46:00 GMT 2016


This patch to the Go frontend implements the go:noinline and
go:nosplit compiler directives.  Bootstrapped and ran Go testsuite on
x86_64-pc-linux-gnu.  Committed to mainline.

Ian
-------------- next part --------------
Index: gcc/go/gofrontend/MERGE
===================================================================
--- gcc/go/gofrontend/MERGE	(revision 239311)
+++ gcc/go/gofrontend/MERGE	(working copy)
@@ -1,4 +1,4 @@
-85a9c6992d9660e36972c279a5252fd9591bb765
+8da2129a005cc1f44d4d993b0b7312b64c0d68a4
 
 The first line of this file holds the git revision number of the last
 merge done from the gofrontend repository.
Index: gcc/go/gofrontend/gogo.cc
===================================================================
--- gcc/go/gofrontend/gogo.cc	(revision 239311)
+++ gcc/go/gofrontend/gogo.cc	(working copy)
@@ -5083,11 +5083,19 @@ Function::get_or_make_decl(Gogo* gogo, N
       if (this->calls_defer_retaddr_)
 	is_inlinable = false;
 
+      // Check the //go:noinline compiler directive.
+      if ((this->pragmas_ & GOPRAGMA_NOINLINE) != 0)
+	is_inlinable = false;
+
       // If this is a thunk created to call a function which calls
       // the predeclared recover function, we need to disable
       // stack splitting for the thunk.
       bool disable_split_stack = this->is_recover_thunk_;
 
+      // Check the //go:nosplit compiler directive.
+      if ((this->pragmas_ & GOPRAGMA_NOSPLIT) != 0)
+	disable_split_stack = true;
+
       // This should go into a unique section if that has been
       // requested elsewhere, or if this is a nointerface function.
       // We want to put a nointerface function into a unique section
Index: gcc/go/gofrontend/lex.cc
===================================================================
--- gcc/go/gofrontend/lex.cc	(revision 239311)
+++ gcc/go/gofrontend/lex.cc	(working copy)
@@ -1842,13 +1842,11 @@ Lex::skip_cpp_comment()
     {
       // Applies to the next function.  Do not split the stack when
       // entering the function.
-      // FIXME: Not implemented.
       this->pragmas_ |= GOPRAGMA_NOSPLIT;
     }
   else if (verb == "go:noinline")
     {
       // Applies to the next function.  Do not inline the function.
-      // FIXME: Not implemented.
       this->pragmas_ |= GOPRAGMA_NOINLINE;
     }
   else if (verb == "go:systemstack")


More information about the Gcc-patches mailing list