[hsa-branch] Remove typedef.*_p from hsa.h

Martin Jambor mjambor@suse.cz
Tue Aug 9 14:28:00 GMT 2016


Hi,

the rest of hsa code uses direct pointers, which I find preferable (and
since we have moved to explicit pointers also for example with the
gimple type, I believe I am not alone, so I removed the two _p typedefs
we had in hsa.h.  They were not in widespread use anyway.

Thanks,

Martin

2016-08-03  Martin Jambor  <mjambor@suse.cz>

	* hsa.h (hsa_insn_basic_p): Remove typedef.
	(hsa_op_with_type): Change hsa_insn_basic_p into plain pointers.
	(hsa_op_reg_p): Remove typedef.
	(hsa_function_representation): Change hsa_op_reg_p into plain
	pointers.
---
 gcc/hsa.h | 7 ++-----
 1 file changed, 2 insertions(+), 5 deletions(-)

diff --git a/gcc/hsa.h b/gcc/hsa.h
index 092fd3b..242103c 100644
--- a/gcc/hsa.h
+++ b/gcc/hsa.h
@@ -50,7 +50,6 @@ class hsa_insn_basic;
 class hsa_op_address;
 class hsa_op_reg;
 class hsa_bb;
-typedef hsa_insn_basic *hsa_insn_basic_p;
 
 /* Class representing an input argument, output argument (result) or a
    variable, that will eventually end up being a symbol directive.  */
@@ -259,11 +258,9 @@ private:
   /* Set definition where the register is defined.  */
   void set_definition (hsa_insn_basic *insn);
   /* Uses of the value while still in SSA.  */
-  auto_vec <hsa_insn_basic_p> m_uses;
+  auto_vec <hsa_insn_basic *> m_uses;
 };
 
-typedef class hsa_op_reg *hsa_op_reg_p;
-
 /* Report whether or not P is a register operand.  */
 
 template <>
@@ -1269,7 +1266,7 @@ public:
   unsigned m_temp_symbol_count;
 
   /* SSA names mapping.  */
-  vec <hsa_op_reg_p> m_ssa_map;
+  vec <hsa_op_reg *> m_ssa_map;
 
   /* Flag whether a function needs update of dominators before RA.  */
   bool m_modified_cfg;
-- 
2.9.2



More information about the Gcc-patches mailing list