[PTX] fix worker propagation ICE

Thomas Schwinge thomas@codesourcery.com
Thu Aug 4 13:52:00 GMT 2016


Hi!

On Wed, 3 Aug 2016 13:30:10 -0400, Nathan Sidwell <nathan@acm.org> wrote:
> --- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c	(nonexistent)
> +++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c	(working copy)
> @@ -0,0 +1,28 @@
> +/* { dg-do compile } */
> +/* { dg-options "-O0" } */

Offloading compilation happens at link time not compile time, and in
OpenACC libgomp testing, we're doing a limited set of torture testing
(-O0, -O2), so no point in hardcoding -O0 here.

As obvious, committed to trunk in r239125:

commit ec8d61ace153843dcaaba86ad926f384a4affee3
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Aug 4 13:34:57 2016 +0000

    Make libgomp.oacc-c-c++-common/crash-1.c a "link" test, and don't hardcode -O0
    
    	libgomp/
    	* testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link"
    	test, and don't hardcode -O0.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/trunk@239125 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog                                     | 5 +++++
 libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c | 5 ++---
 2 files changed, 7 insertions(+), 3 deletions(-)

diff --git libgomp/ChangeLog libgomp/ChangeLog
index 850188f..cc76b7b 100644
--- libgomp/ChangeLog
+++ libgomp/ChangeLog
@@ -1,3 +1,8 @@
+2016-08-04  Thomas Schwinge  <thomas@codesourcery.com>
+
+	* testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link"
+	test, and don't hardcode -O0.
+
 2016-08-03  Nathan Sidwell  <nathan@codesourcery.com>
 
 	* testsuite/libgomp.oacc-c-c++-common/crash-1.c: New.
diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c
index a75a817..dcf1485 100644
--- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c
@@ -1,7 +1,6 @@
-/* { dg-do compile } */
-/* { dg-options "-O0" } */
+/* { dg-do link } */
 
-/* ICEd in nvptx backend due to unexpected frame size.  */
+/* For -O0, ICEd in nvptx backend due to unexpected frame size.  */
 #pragma acc routine worker
 void
 worker_matmul (int *c, int i)

Backported to gomp-4_0-branch in r239129:

commit bab445509b917c582a53834599f614ce2c29ff36
Author: tschwinge <tschwinge@138bc75d-0d04-0410-961f-82ee72b054a4>
Date:   Thu Aug 4 13:49:15 2016 +0000

    Make libgomp.oacc-c-c++-common/crash-1.c a "link" test, and don't hardcode -O0
    
    Backport trunk r239125:
    
    	libgomp/
    	* testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link"
    	test, and don't hardcode -O0.
    
    git-svn-id: svn+ssh://gcc.gnu.org/svn/gcc/branches/gomp-4_0-branch@239129 138bc75d-0d04-0410-961f-82ee72b054a4
---
 libgomp/ChangeLog.gomp                                | 6 ++++++
 libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c | 5 ++---
 2 files changed, 8 insertions(+), 3 deletions(-)

diff --git libgomp/ChangeLog.gomp libgomp/ChangeLog.gomp
index 7a7d859..4320237 100644
--- libgomp/ChangeLog.gomp
+++ libgomp/ChangeLog.gomp
@@ -1,3 +1,9 @@
+2016-08-04  Thomas Schwinge  <thomas@codesourcery.com>
+
+	Backport trunk r239125:
+	* testsuite/libgomp.oacc-c-c++-common/crash-1.c: Make it a "link"
+	test, and don't hardcode -O0.
+
 2016-08-03  Nathan Sidwell  <nathan@codesourcery.com>
 
 	* testsuite/libgomp.oacc-c-c++-common/crash-1.c: New.
diff --git libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c
index a75a817..dcf1485 100644
--- libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c
+++ libgomp/testsuite/libgomp.oacc-c-c++-common/crash-1.c
@@ -1,7 +1,6 @@
-/* { dg-do compile } */
-/* { dg-options "-O0" } */
+/* { dg-do link } */
 
-/* ICEd in nvptx backend due to unexpected frame size.  */
+/* For -O0, ICEd in nvptx backend due to unexpected frame size.  */
 #pragma acc routine worker
 void
 worker_matmul (int *c, int i)


Grüße
 Thomas
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 472 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20160804/2bb1458c/attachment.sig>


More information about the Gcc-patches mailing list