[PATCH 1/2] Fix GNU coding style in gcov.c

Nathan Sidwell nathan@acm.org
Thu Aug 4 11:39:00 GMT 2016


On 08/04/16 06:39, Martin Liška wrote:
> On 08/03/2016 04:22 PM, Nathan Sidwell wrote:
>> Martin,
>>> As I've going through all PRs related to gcov-profile, I've noticed this PR.
>>> Current implementation of cycle detection in gcov is very poor, leading to extreme run time
>>> for cases like mentioned in the PR (which does not contain a cycle). Thank to Joshua, I've
>>> grabbed his patch and removed the scaffolding (classes: Arc, Block, ...) he did. After doing that
>>> the patch is quite subtle and fast (of course).
>>
>> sorry to be a pain, but could you split the patch into
>> a) formatting changes
>> b) the clever  bits
>>
>> the formatting changes can then (probably) be applied as obvious.
>>
>> nathan
>
> That's all right, it's my mistake that I messed up coding style issues and
> core of that patch.

Thanks.  the formatting patch is fine.  Reading the other one next ...

nathan



More information about the Gcc-patches mailing list