[PATCH, i386]: Extend TARGET_READ_MODIFY{,_WRITE} peepholes to all integer modes

Uros Bizjak ubizjak@gmail.com
Fri Apr 29 07:50:00 GMT 2016


On Fri, Apr 29, 2016 at 9:47 AM, Eric Botcazou <ebotcazou@adacore.com> wrote:
>> While looking at the insn enable condition, I noticed that we don't
>> use "probe_stack" pattern any more, as the stack check loop is now
>> implemented in a different way.
>
> Yes, we do, probe_stack is a standard pattern called by the middle-end.
>
>> 2016-04-28  Uros Bizjak  <ubizjak@gmail.com>
>>
>>     * config/i386/i386.md (peephole2s for operations with memory inputs):
>>     Use SWI mode iterator.
>>     (peephole2s for operations with memory outputs): Ditto.
>>     Do not check for stack checking probe.
>>
>>     (probe_stack): Remove expander.
>>
>> Patch was bootstrapped and regression tested on x86_64-linux-gnu {,-m32}.
>
> How did you test it exactly?
>
>                 === acats tests ===
> FAIL:   c52103x
> FAIL:   c52104x

Apparently without ada...

We can put it back, but prehaps implemented as unspec, so it won't
interfere with peepholes?

Uros.



More information about the Gcc-patches mailing list