Patches to fix optimizer bug & C++ exceptions for GCC VAX backend

Jeff Law law@redhat.com
Tue Apr 26 16:27:00 GMT 2016


On 04/01/2016 05:37 AM, Bernd Schmidt wrote:
> Cc'ing Matt Thomas who is listed as the vax maintainer; most of the
> patch should be reviewed by him IMO. If he is no longer active I'd
> frankly rather deprecate the port rather than invest effort in keeping
> it running.
>
>> Index: gcc/except.c
>> ===================================================================
>> RCS file: /cvsroot/src/external/gpl3/gcc/dist/gcc/except.c,v
>> retrieving revision 1.3
>> diff -u -r1.3 except.c
>> --- gcc/except.c    23 Mar 2016 15:51:36 -0000    1.3
>> +++ gcc/except.c    28 Mar 2016 23:24:40 -0000
>> @@ -2288,7 +2288,8 @@
>>   #endif
>>       {
>>   #ifdef EH_RETURN_HANDLER_RTX
>> -      emit_move_insn (EH_RETURN_HANDLER_RTX, crtl->eh.ehr_handler);
>> +      rtx insn = emit_move_insn (EH_RETURN_HANDLER_RTX,
>> crtl->eh.ehr_handler);
>> +      RTX_FRAME_RELATED_P (insn) = 1;    // XXX FIXME in VAX backend?
>>   #else
>>         error ("__builtin_eh_return not supported on this target");
>>   #endif
>
> This part looks highly suspicious and I think there needs to be further
> analysis.
Agreed 100%.  This is a symptom of a problem elsewhere.

jeff



More information about the Gcc-patches mailing list