[PATCH] Don't build 32-bit libatomic with -march=i486 on x86-64

[H.J. Lu]

On Wed, Apr 20, 2016 at 12:02 AM, Uros Bizjak <ubizjak@gmail.com> wrote:
>>
>> That is why I submitted my patches.  Since -m32 passes -march=x86-64
>> to cc1 on x86-64,  we shouldn't pass -march=i486 to cc1.  It is undesirable
>> especially when --with-arch= is used.  I noticed the issue when 32-bit
>> libatomic/libgomp/libitm weren't optimized with -march=haswell when GCC
>> was configured with --with-arch=haswell
>
> OK then. IMO, following comment is more informative:
>
> # x86_64 compiler passes -march=x86_64 by default when building 32bit
> target libraries.
>
>>>>>>>> +       # Since 64-bit arch > i486, we can use the same -march= to build
>>>>>>>> +       # both 32-bit and 64-bit target libraries.
>
> OK with the above change.
>

This is the patch I checked in.  I also updated patches for libgomp:

https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01079.html

and libitm:

https://gcc.gnu.org/ml/gcc-patches/2016-04/msg01080.html

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Don-t-build-32-bit-libatomic-with-march-i486-on-x86-.patch
Type: text/x-patch
Size: 1188 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20160420/f3e4129f/attachment.bin>