RFC: C++ PATCH to adjust empty class parameter passing ABI
H.J. Lu
hjl.tools@gmail.com
Thu Apr 14 00:35:00 GMT 2016
On Wed, Apr 13, 2016 at 1:12 PM, Jason Merrill <jason@redhat.com> wrote:
> On 04/13/2016 03:18 PM, Jakub Jelinek wrote:
>>
>> On Wed, Apr 13, 2016 at 03:11:34PM -0400, Jason Merrill wrote:
>>>
>>> commit 761983a023b5217ef831a43f423779940c788ecf
>>> Author: Jason Merrill <jason@redhat.com>
>>> Date: Tue Apr 12 13:16:50 2016 -0400
>>>
>>> gcc/
>>> * cfgexpand.c (pass_expand::execute): Handle attribute
>>> abi_warning.
>>> * expr.c (expand_expr_real_1): Likewise.
>>> gcc/cp/
>>> * call.c (empty_class_msg, mark_for_abi_warning): New.
>>> (build_call_a): Use them.
>>> * decl.c (store_parm_decls): Use mark_for_abi_warning.
>>> * error.c (pp_format_to_string): New.
>>
>>
>> I think you should put a space into the attribute name instead of _
>> to make it clear that it is not an attribute users can use directly in
>> their
>> code through __attribute__.
>>
>> Otherwise it looks reasonable to me.
>
>
> Thanks, applied with that change.
I opened:
https://gcc.gnu.org/bugzilla/show_bug.cgi?id=70649
--
H.J.
More information about the Gcc-patches
mailing list