[PATCH 3/4] bb-reorder: Add -freorder-blocks-algorithm= and wire it up
Thu Sep 24 14:06:00 GMT 2015
On Thu, Sep 24, 2015 at 12:28:08PM +0200, Bernd Schmidt wrote:
> On 09/24/2015 12:06 AM, Segher Boessenkool wrote:
> >This adds an -freorder-blocks-algorithm=[simple|stc] flag, with "simple"
> >as default. For -O2 and up (except -Os) it is switched to "stc" instead.
> >Targets that never want STC can override this. This changes
> >to be on at -O1 and up (was -O2 and up).
> >In effect, the changes are for -O1 (which now gets "simple" instead of
> >nothing), -Os (which now gets "simple" instead of "stc", since STC results
> >in much bigger code), and for targets that wish to never use STC (not in
> >this patch though).
> This should be merged with its documentation in 4/4, and personally I'd
> have no problem reviewing a patch with 2/3/4 all in one. Splitting
> patches is most helpful if there are parts that rearrange things such as
> your 1/4, or if there are multiple independent functional changes. I'm
> not saying you did anything wrong by splitting, just that maybe you made
> unnecessary work for yourself.
I had the patches like that in my git tree, so I figured I'd send it like
that, makes review slightly easier (not a big deal for small patches like
this of course). I did not waste time splitting things up, don't worry :-)
More information about the Gcc-patches