PR pretty-print/67567 do not pass NULL as a string

Manuel López-Ibáñez lopezibanez@gmail.com
Sun Sep 20 19:14:00 GMT 2015


PING: https://gcc.gnu.org/ml/gcc-patches/2015-09/msg01219.html

On 16 September 2015 at 19:45, Manuel López-Ibáñez
<lopezibanez@gmail.com> wrote:
> Fortran passes NULL where a non-null string is expected by the pretty-printer,
> which causes a sanitizer warning. This could have been found earlier by using
> gcc_checking_assert. Even if the assertion is false, the result is just an
> incomplete diagnostic, thus it seems more user-friendly to assert only when
> checking. I do not have any idea how to properly fix the Fortran bug, thus this
> patch simply works-around it.
>
> Bootstrapped & regtested on x86_64-linux-gnu.
>
> OK?
>
> gcc/fortran/ChangeLog:
>
> 2015-09-15  Manuel López-Ibáñez  <manu@gcc.gnu.org>
>
>     PR pretty-print/67567
>     * resolve.c (resolve_fl_procedure): Work-around when iface->module
>     == NULL.
>
> gcc/ChangeLog:
>
> 2015-09-15  Manuel López-Ibáñez  <manu@gcc.gnu.org>
>
>     PR pretty-print/67567
>     * pretty-print.c (pp_string): Add gcc_checking_assert.
>     * pretty-print.h (output_buffer_append_r): Likewise.



More information about the Gcc-patches mailing list