[PATCH 01/22] Change of location_get_source_line signature

David Malcolm dmalcolm@redhat.com
Tue Sep 15 17:02:00 GMT 2015


On Mon, 2015-09-14 at 13:26 -0600, Jeff Law wrote:
> On 09/10/2015 02:28 PM, David Malcolm wrote:
> > location_get_source_line takes an expanded_location, but the column
> > is irrelevant; it just needs a filename and line number.
> >
> > This change is used by, but independent of, the new implementation of
> > diagnostic_show_locus later in the kit, so am breaking this out early.
> >
> > gcc/ChangeLog:
> > 	* input.h (location_get_source_line): Drop "expanded_location"
> > 	param in favor of a file and line number.
> > 	* input.c (location_get_source_line): Likewise.
> > 	(dump_location_info): Update for change in signature of
> > 	location_get_source_line.
> > 	* diagnostic.c (diagnostic_print_caret_line): Likewise.
> >
> > gcc/c-family/ChangeLog:
> > 	* c-format.c (location_from_offset): Update for change in
> > 	signature of location_get_source_line.
> > 	* c-indentation.c (get_visual_column): Likewise.
> > 	(line_contains_hash_if): Likewise.
> This looks like a reasonable cleanup in and of itself.  It's OK for the 
> trunk once you've done the usual bootstrap & regression test.

Thanks; bootstrapped®rtested; committed to trunk as r227800.




More information about the Gcc-patches mailing list