[PATCH] [ARM, Callgraph] Fix PR67280: function incorrectly marked as nothrow

Charles Baylis charles.baylis@linaro.org
Mon Sep 7 08:48:00 GMT 2015


On 2 September 2015 at 13:09, Jan Hubicka <hubicka@ucw.cz> wrote:
> It kind of sucks that one needs to mind this flag each time one creates edge,
> but setting the value in create_edge is not quite correct as that one does not
> have any information on where the call appears and if the exception is not handled
> locally.

OK.

>> >gcc/ChangeLog:
>> >
>> >2015-08-28  Charles Baylis  <charles.baylis@linaro.org>
>> >
>> >         * cgraphunit.c (cgraph_node::create_wrapper): Set can_throw_external
>> >         in new callgraph edge.
>> Ultimately Jan's call.
>
> This is OK.
> Thanks for looking into this!

Thanks for the review!

FWIW, the patch successfully bootstrapped on arm-linux-gnueabihf

Committed to trunk as r227407.

Are you happy for me to backport to gcc-5-branch?

Charles



More information about the Gcc-patches mailing list