[AArch64][PATCH 2/7] Add sqrdmah, sqrdmsh instructions.
James Greenhalgh
james.greenhalgh@arm.com
Tue Oct 27 16:30:00 GMT 2015
On Tue, Oct 27, 2015 at 04:11:07PM +0000, Matthew Wahab wrote:
> On 27/10/15 11:18, James Greenhalgh wrote:
>
> >> ;; -------------------------------------------------------------------
> >>@@ -932,6 +934,8 @@
> >> UNSPEC_SQSHRN UNSPEC_UQSHRN
> >> UNSPEC_SQRSHRN UNSPEC_UQRSHRN])
> >>
> >>+(define_int_iterator SQRDMLAH [UNSPEC_SQRDMLAH UNSPEC_SQRDMLSH])
> >>+
> >
> >This name does not make it clear that you will iterate over an "A" and an
> >"S" form. I'd like to see a clearer naming choice, RDMAS? SQRDMLHADDSUB? etc.
>
> SQRDMLHADDSUB is a little difficult to read. How about SQRDMLH_AS,
> to keep the link to the instruction?
Sounds good to me.
Thanks,
James
More information about the Gcc-patches
mailing list