[PATCH] gcc/fold-const.c: Correct the report warning position.

Richard Biener richard.guenther@gmail.com
Fri Oct 23 09:06:00 GMT 2015


On Thu, Oct 22, 2015 at 9:46 PM, Jeff Law <law@redhat.com> wrote:
> On 10/21/2015 04:31 PM, Chen Gang wrote:
>>
>> Hello all:
>>
>> It is for bug63510, which reported by another members (not me), I guess,
>> this patch should fix this bug.
>>
>> Welcome any other members' ideas, suggestions, and completions.
>
> Note that the call to fold_binary from tree-ssa-sccvn.c has been removed.
> So that hunk either needs to be removed or the change applied elsewhere.
>
> I think passing around the location through fold-const.c is OK.
>
> I'd like to see a testcase in a form ready for inclusion into the testsuite.

As an additional remark - I'd like to see us not use input_location
but always loc,
even if UNKNOWN_LOCATION.  The diagnostic machinery should handle this
correctly(?).  That is, if bootstrap/testign doesn't show testsuite
regressions because
of this.

Richard.

> jeff
>



More information about the Gcc-patches mailing list