[PATCH v2] PR rtl-optimization/66790: uninitialized registers handling in REE

[Pierre-Marie de Rodat]

On 10/14/2015 09:41 AM, Bernd Schmidt wrote:
> This one is OK with minor changes. I ran some tests with it, and the mir
> sets look good this time. Code generation still seems unaffected by it
> on all my example code (which is as expected).

Thank you very much for your help on this and for double-checking!

>> +  /* Ignoring artificial defs is intentionnal: these often pretend
>> that some
>
> "intentional".

Fixed.

> Please remove the commented out code and then also the unnecessary
> braces. In general we avoid commented out code in gcc, but when doing
> it, #if 0 is generally a better method.

Ok, this is removed.

>> +      const rtx reg = XEXP (src, 0);
>
> Drop the const maybe? It doesn't seem to add much and the idiom is to
> just use rtx.

Done.

>> Subject: [PATCH 2/2] DF_LIVE: make clobbers cancel effect of previous
>> GENs in
>>   the same BBs
>>
>> gcc/ChangeLog:
>>
>>     * df-problems.c (df_live_bb_local_compute): Clear GEN bits for
>>     DF_REF_MUST_CLOBBER references.
>
> This one is probably ok too; I still want to experiment with it a little.

Sure, I only committed the attached updated first patch.

-- 
Pierre-Marie de Rodat
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-REE-fix-uninitialized-registers-handling.patch
Type: text/x-diff
Size: 26830 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20151019/1959c8d8/attachment.bin>