PING: [PATCH] PR bootstrap/67385: READELF_FOR_TARGET isn't used in gcc configure

H.J. Lu hjl.tools@gmail.com
Wed Oct 7 12:30:00 GMT 2015


PING

On Fri, Sep 4, 2015 at 7:51 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Aug 28, 2015 at 8:50 AM, H.J. Lu <hongjiu.lu@intel.com> wrote:
>> Similar to as, ld, nm and objdump, gcc configure should check
>> $READELF_FOR_TARGET for readelf.
>>
>> OK for trunk?
>>
>> H.J.
>> ---
>>         PR bootstrap/67385
>>         * configure.ac (gcc_cv_readelf): Check $READELF_FOR_TARGET.
>>         * configure: Regenerated.
>> ---
>>  gcc/configure    | 6 ++++--
>>  gcc/configure.ac | 4 +++-
>>  2 files changed, 7 insertions(+), 3 deletions(-)
>>
>> diff --git a/gcc/configure b/gcc/configure
>> index 0d31383..4d16140 100755
>> --- a/gcc/configure
>> +++ b/gcc/configure
>> @@ -22232,9 +22232,11 @@ if test -f $gcc_cv_binutils_srcdir/configure.ac \
>>         gcc_cv_readelf=../binutils/readelf$build_exeext
>>  elif test -x readelf$build_exeext; then
>>         gcc_cv_readelf=./readelf$build_exeext
>> +elif ( set dummy $READELF_FOR_TARGET; test -x $2 ); then
>> +        gcc_cv_readelf="$READELF_FOR_TARGET"
>>  else
>> -        # Extract the first word of "readelf", so it can be a program name with args.
>> -set dummy readelf; ac_word=$2
>> +        # Extract the first word of "$READELF_FOR_TARGET", so it can be a program name with args.
>> +set dummy $READELF_FOR_TARGET; ac_word=$2
>>  { $as_echo "$as_me:${as_lineno-$LINENO}: checking for $ac_word" >&5
>>  $as_echo_n "checking for $ac_word... " >&6; }
>>  if test "${ac_cv_path_gcc_cv_readelf+set}" = set; then :
>> diff --git a/gcc/configure.ac b/gcc/configure.ac
>> index 846651d..81aba21 100644
>> --- a/gcc/configure.ac
>> +++ b/gcc/configure.ac
>> @@ -2367,8 +2367,10 @@ if test -f $gcc_cv_binutils_srcdir/configure.ac \
>>         gcc_cv_readelf=../binutils/readelf$build_exeext
>>  elif test -x readelf$build_exeext; then
>>         gcc_cv_readelf=./readelf$build_exeext
>> +elif ( set dummy $READELF_FOR_TARGET; test -x $[2] ); then
>> +        gcc_cv_readelf="$READELF_FOR_TARGET"
>>  else
>> -        AC_PATH_PROG(gcc_cv_readelf, readelf)
>> +        AC_PATH_PROG(gcc_cv_readelf, $READELF_FOR_TARGET)
>>  fi])
>>
>>  AC_MSG_CHECKING(what readelf to use)
>> --
>> 2.4.3
>>
>
> Any comments, objections, feedbacks?
>
> --
> H.J.



-- 
H.J.



More information about the Gcc-patches mailing list