[PR68432 04/22] Remove global which_alternative

[Richard Sandiford]

Bernd Schmidt <bschmidt@redhat.com> writes:
> On 11/25/2015 05:19 PM, Richard Sandiford wrote:
>> I guess not, but without it we have both local and global variables
>> called which_alternative.
>
> So call the local ones something else (alt_to_check, requested_alt or 
> attr_alt)?

Well, having two names for the same concept seems just as bad.
Especially since the traditional which_alternative will still
be defined and accessible.

We could have another #define hack to insert a _Pragma("GCC error ...")
if which_alternative is used in new-style attributes, but that's only
going to avoid some of the problems.

I don't think we should spend too much effort finding a reason not
to fix this...

Thanks,
Richard