acc_on_device for device_type_host_nonshm

H.J. Lu hjl.tools@gmail.com
Thu May 28 11:56:00 GMT 2015


On Thu, May 21, 2015 at 4:10 AM, Jakub Jelinek <jakub@redhat.com> wrote:
> On Thu, May 21, 2015 at 01:02:12PM +0200, Thomas Schwinge wrote:
>> Hi!
>>
>> On Thu, 7 May 2015 19:32:26 +0100, Julian Brown <julian@codesourcery.com> wrote:
>> > Here's a new version of the patch [...]
>>
>> > OK for trunk?
>>
>> Makes sense to me (with just a request to drop the testsuite changes, see
>> below), to get the existing regressions under control.  Jakub?
>
> Ok for trunk.
>>
>> >     PR libgomp/65742
>> >
>> >     gcc/
>> >     * builtins.c (expand_builtin_acc_on_device): Don't use open-coded
>> >     sequence for !ACCEL_COMPILER.
>> >

It breaks bootstrap on x86:

https://gcc.gnu.org/ml/gcc-regression/2015-05/msg00389.html

I checked in this to fix it.

-- 
H.J.
---
Index: gcc/ChangeLog
===================================================================
--- gcc/ChangeLog (revision 223804)
+++ gcc/ChangeLog (working copy)
@@ -1,3 +1,8 @@
+2015-05-28  H.J. Lu  <hongjiu.lu@intel.com>
+
+ * builtins.c (expand_builtin_acc_on_device): Mark parameters
+ with ATTRIBUTE_UNUSED.
+
 2015-05-28  Julian Brown  <julian@codesourcery.com>

  PR libgomp/65742
Index: gcc/builtins.c
===================================================================
--- gcc/builtins.c (revision 223804)
+++ gcc/builtins.c (working copy)
@@ -5911,7 +5911,8 @@
    acceleration device (ACCEL_COMPILER conditional).  */

 static rtx
-expand_builtin_acc_on_device (tree exp, rtx target)
+expand_builtin_acc_on_device (tree exp ATTRIBUTE_UNUSED,
+      rtx target ATTRIBUTE_UNUSED)
 {
 #ifdef ACCEL_COMPILER
   if (!validate_arglist (exp, INTEGER_TYPE, VOID_TYPE))



More information about the Gcc-patches mailing list