[PATCH, x86, libgomp, libitm]: Remove __PIC__ versions of syscall
Uros Bizjak
ubizjak@gmail.com
Wed May 27 20:51:00 GMT 2015
On Wed, May 27, 2015 at 10:09 PM, Richard Henderson <rth@redhat.com> wrote:
> On 05/27/2015 12:40 PM, Uros Bizjak wrote:
>> Also, fix function operand type to match the operand type.
>
> Why do you believe op to be of type "long"?
> Certainly man 2 futex doesn't say that.
In libgomp/config/linux/wait.h, we have:
extern long int gomp_futex_wait, gomp_futex_wake;
These are passed in libgomp/config/linux/x86/futex.h as:
long res = sys_futex0 (addr, gomp_futex_wait, val);
Considering that x86 is an ILP32 target, and looking at x86_64's
sys_futex0 in libitm/config/linux/x86 I choose long here. If we want
to follow futex manpage, we probably need to redefine gomp_futex_wait
and gomp_futex_wake as a plain int.
Uros.
More information about the Gcc-patches
mailing list