Calculate TYPE_CANONICAL only for types that can be accessed in memory

H.J. Lu hjl.tools@gmail.com
Sun May 24 14:47:00 GMT 2015


On Sun, May 24, 2015 at 5:49 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, May 22, 2015 at 5:00 AM, Jan Hubicka <hubicka@ucw.cz> wrote:
>>> Now we have it spelled out 4 times ... makes sense to create a new
>>> macro for it?  (though I cannot think of a good name...
>>> UNACCESSIBLE_TYPE_P ()?)
>>
>> Yep, actually I already made that version of patch yesterday but then got
>> hooked by beers.  This is better version (also with more sensible comments).
>> I will commit it at afternoon if you have no further comments.
>>
>>
>>         * lto.c (hash_canonical_type): Be sure we hash only types that
>>         need alias set.
>>         (gimple_register_canonical_type_1): Do not produce canonical
>>         types for types that do not need alias sets.
>>         * tree.c (gimple_canonical_types_compatible_p): Sanity check that
>>         we do not try to compute canonical type for type that does not need
>>         alias set.
>>         (verify_type): Drop FIXME for METHOD_TYPE, update FIXME for
>>         FUNCITON_TYPE.
>>         * tree.h (type_with_alias_set_p): New.
>
> This caused:
>
> https://gcc.gnu.org/ml/gcc-cvs/2015-05/msg00948.html

I meant:

https://gcc.gnu.org/bugzilla/show_bug.cgi?id=66273


-- 
H.J.



More information about the Gcc-patches mailing list