[PATCH] PR target/66232: -fPIC -fno-plt -mx32 fails to generate indirect branch via GOT

[H.J. Lu]

On Thu, May 21, 2015 at 12:01 PM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Thu, May 21, 2015 at 11:41 AM, Richard Henderson <rth@redhat.com> wrote:
>> On 05/21/2015 05:59 AM, H.J. Lu wrote:
>>> +(define_predicate "x32_sibcall_memory_operand"
>>> +  (and (match_operand 0 "memory_operand")
>>> +       (match_test "CONSTANT_P (XEXP (op, 0))")
>>> +       (match_test "GET_CODE (XEXP (XEXP (op, 0), 0)) == UNSPEC")
>>> +       (match_test "XINT (XEXP (XEXP (op, 0), 0), 1) == UNSPEC_GOTPCREL")))
>>
>> CONSTANT_P doesn't do what you think it does.  That accepts all constants, not
>> the CONST rtx code, which is the only thing you want to be looking into its XEXP.
>>
>
> Hope this is the final one :-).
>

This is what I checked in.

Thanks.

-- 
H.J.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Allow-indirect-branch-via-GOT-slot-for-x32.patch
Type: text/x-patch
Size: 7274 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150521/2862cbc7/attachment.bin>