[PATCH] fortran/66052 -- Prevent dereference of NULL pointer

Steve Kargl sgk@troutmask.apl.washington.edu
Mon May 18 23:00:00 GMT 2015


On Sat, May 16, 2015 at 01:58:30PM +0200, Mikael Morin wrote:
> > Index: gcc/fortran/decl.c
> > ===================================================================
> > --- gcc/fortran/decl.c	(revision 223094)
> > +++ gcc/fortran/decl.c	(working copy)
> > @@ -6968,7 +6968,8 @@ gfc_match_protected (void)
> >    gfc_symbol *sym;
> >    match m;
> >  
> > -  if (gfc_current_ns->proc_name->attr.flavor != FL_MODULE)
> > +  if (gfc_current_ns->proc_name
> > +      && gfc_current_ns->proc_name->attr.flavor != FL_MODULE)
> >      {
> >         gfc_error ("PROTECTED at %C only allowed in specification "
> >  		  "part of a module");
> 
> Wouldn't one get a slightly better error message if using
> 	!gfc_current_ns->proc_name
> 	|| gfc_current_ns->proc_name->attr.flavor != FL_MODULE
> as condition ?
> 
> OK with that change.  Thanks.
> 

Committed ar r223324 with your suggested change.  Indeed, 
a better error messaage emitted.

-- 
Steve



More information about the Gcc-patches mailing list