[PATCH][AArch64] Removed unused SLOWMUL target flags

James Greenhalgh james.greenhalgh@arm.com
Fri May 15 09:44:00 GMT 2015


On Fri, May 15, 2015 at 09:04:52AM +0100, Kyrill Tkachov wrote:
> Hi all,
> 
> It seems that AARCH64_TUNE_SLOWMUL somehow slipped from the arm backend into the aarch64 one.
> This macro is not used anywhere and I don't expect it will be used. It has been there since
> October 2012 i.e. when the port was first contributed.
> This patch removes that and the relevant AARCH64_FL_SLOWMUL flag definition as well.
> 
> Bootstrapped and tested on aarch64.

Looks obvious to me, please apply.

Note that, as I've mentioned in the past, you don't need to ask for
approval for such obvious patches, this is cleaning up obviously dead
code.

See https://gcc.gnu.org/svnwrite.html#policies for details of the policy
for obvious fixes (under the section "Free for all").

Thanks,
James

> 2015-05-15  Kyrylo Tkachov  <kyrylo.tkachov@arm.com>
> 
>      * config/aarch64/aarch64.h (AARCH64_TUNE_SLOWMUL): Delete.
>      (AARCH64_FL_SLOWMUL): Delete.
>      (AARCH64_FL_CRC): Redefine to 1<<3.
>      (AARCH64_FL_USE_FMA_STEERING_PASS): Redefine to 1<<4.

> diff --git a/gcc/config/aarch64/aarch64.h b/gcc/config/aarch64/aarch64.h
> index c85d279..25b9927 100644
> --- a/gcc/config/aarch64/aarch64.h
> +++ b/gcc/config/aarch64/aarch64.h
> @@ -198,10 +198,9 @@ extern unsigned aarch64_architecture_version;
>  #define AARCH64_FL_SIMD       (1 << 0)	/* Has SIMD instructions.  */
>  #define AARCH64_FL_FP         (1 << 1)	/* Has FP.  */
>  #define AARCH64_FL_CRYPTO     (1 << 2)	/* Has crypto.  */
> -#define AARCH64_FL_SLOWMUL    (1 << 3)	/* A slow multiply core.  */
> -#define AARCH64_FL_CRC        (1 << 4)	/* Has CRC.  */
> +#define AARCH64_FL_CRC        (1 << 3)	/* Has CRC.  */
>  /* Has static dispatch of FMA.  */
> -#define AARCH64_FL_USE_FMA_STEERING_PASS (1 << 5)
> +#define AARCH64_FL_USE_FMA_STEERING_PASS (1 << 4)
>  
>  /* Has FP and SIMD.  */
>  #define AARCH64_FL_FPSIMD     (AARCH64_FL_FP | AARCH64_FL_SIMD)
> @@ -221,7 +220,6 @@ extern unsigned long aarch64_isa_flags;
>  
>  /* Macros to test tuning flags.  */
>  extern unsigned long aarch64_tune_flags;
> -#define AARCH64_TUNE_SLOWMUL       (aarch64_tune_flags & AARCH64_FL_SLOWMUL)
>  #define AARCH64_TUNE_FMA_STEERING \
>    (aarch64_tune_flags & AARCH64_FL_USE_FMA_STEERING_PASS)
>  



More information about the Gcc-patches mailing list