[PATCH 3/3] Fix indentation issues seen by -Wmisleading-indentation

David Malcolm dmalcolm@redhat.com
Tue May 5 19:44:00 GMT 2015


On Wed, 2015-04-29 at 14:10 +0200, Mikael Morin wrote:
> Hello,
> 
> Le 29/04/2015 02:02, David Malcolm a écrit :
> > diff --git a/gcc/fortran/parse.c b/gcc/fortran/parse.c
> > index 2c7c554..30e4eab 100644
> > --- a/gcc/fortran/parse.c
> > +++ b/gcc/fortran/parse.c
> > @@ -4283,7 +4283,7 @@ parse_oacc_structured_block (gfc_statement acc_st)
> >  	unexpected_eof ();
> >        else if (st != acc_end_st)
> >  	gfc_error ("Expecting %s at %C", gfc_ascii_statement (acc_end_st));
> > -	reject_statement ();
> > +      reject_statement ();
> >      }
> >    while (st != acc_end_st);
> >  
> I think this one is a bug; there should be braces around 'gfc_error' and
> 'reject_statement'.
> At least that's the pattern in 'parse_oacc_loop', and how the
> 'unexpected_statement' function is used.
> Author CC'ed in any case.

Thanks.

FWIW, Jeff had approved that patch, so I've committed the patch to trunk
(as r222823), making the indentation reflect the block structure.

Thomas:  should the
      reject_statement ();
call in the above be guarded by the
     else if (st != acc_end_st)
clause?

Thanks
Dave




More information about the Gcc-patches mailing list