[PATCH] Fix PR ipa/65318

[Martin Liška]

On 03/05/2015 03:29 PM, Marek Polacek wrote:
> On Thu, Mar 05, 2015 at 02:53:44PM +0100, Martin Liška wrote:
>> --- a/gcc/ipa-icf.c
>> +++ b/gcc/ipa-icf.c
>> @@ -1501,6 +1501,11 @@ sem_variable::equals (sem_item *item,
>>     if (DECL_INITIAL (item->decl) == error_mark_node && in_lto_p)
>>       dyn_cast <varpool_node *>(item->node)->get_constructor ();
>>
>> +  /* As seen in PR ipa/65303 we have to compare variable's types.  */
>
> "variables"?
>
>> +  if (!func_checker::compatible_types_p(TREE_TYPE (decl),
>
> Missing space before paren.
>
>> +					TREE_TYPE (item->decl)))
>> +    return return_false_with_msg ("variable types are different");
>
> Here "variables" as well?
>
>> --- /dev/null
>> +++ b/gcc/testsuite/gcc.dg/ipa/PR65318.c
>
> Why PR* and not pr*, which is common?
>
> 	Marek
>

You are right, pr* is more common.
Other nits are fixed in updated version of patch.

Thanks,
Martin
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Fix-PR-ipa-65318.patch
Type: text/x-patch
Size: 1837 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150305/312cbd4c/attachment.bin>