[02/13] Replace handle_cache_entry with new interface
Jeff Law
law@redhat.com
Wed Jun 24 17:10:00 GMT 2015
On 06/24/2015 02:16 AM, Richard Sandiford wrote:
>> So for all the keep_cache_entry functions, I guess they're trivial
>> enough that a function comment probably isn't needed.
>
> Yeah. For cases like this where the function is implementing a defined
> interface (described in hash-table.h), I think it's better to only have
> comments for implementations that are doing something non-obvious.
That works for me.
>
>> Presumably no good way to share the trivial implementation?
>
> Probably not without sharing the other parts of the traits in some way.
> That might be another possible cleanup :-)
I'll let you decide whether or not to pursue. I'd like to hope that ICF
would help us here.
jeff
More information about the Gcc-patches
mailing list