[PATCH] Make muser-mode the default for LEON3

[Daniel Cederman]

On 2015-06-23 14:34, Jakub Jelinek wrote:
> On Tue, Jun 23, 2015 at 02:22:34PM +0200, Daniel Cederman wrote:
>> The muser-mode flag causes the CASA instruction for LEON3 to use the
>> user mode ASI. This is the correct behavior for almost all LEON3 targets.
>> For this reason it makes sense to make user mode the default. This patch
>> adds a flag for supervisor mode that can be used on the very few LEON3 targets
>> that requires CASA to use the supervisor ASI.
>
> Why are you adding a new option and without deprecation removing a
> previously accepted (at least since 4.8) option?
> For just changing the default, you really don't need to add a new option
> or remove -mno-user-mode, just change the default, which can be done
> e.g. by checking if the bit has been explicitly set and if not, use the
> desired default, or if you want to change the Mask() name, just
> make it InverseMask, but keep the options as they are.
>
> 	Jakub
>

How does one check if the bit has been explicitly set? It was not 
obvious to me, which is why I took a similar approach to a patch I found 
for another CPU target. If it is possible to change the default without 
adding another flag then that is obviously better and I will update my 
patch.

Best regards,
Daniel Cederman