[Patch, fortran, PR44672, v10] [F08] ALLOCATE with SOURCE and no array-spec

[Andre Vehreschild]

Hi Thomas,

thanks for the review and valuing my effort. 

I am on travel over the weekend, i.e., I will commit the job earliest on Monday
giving objections a bit more time.

Regards and thanks,
	Andre

On Thu, 11 Jun 2015 23:59:48 +0200
Thomas Koenig <tkoenig@netcologne.de> wrote:

> Hi Andre,
> 
> > please find attached an updated version of the patch. This patch simplifies
> > some cases and ensures more straight line code. Furthermore was a bug in the
> > interfacing routine for the _vptr->_copy() routine removed, where not the
> > third and fourth arguments translated to be passed be value but the fourth
> > and fifth (cs start counting at zero...).
> > 
> > Bootstraps and regtests fine on x86_64-linux-gnu/f21.
> > 
> > Ok for trunk?
> 
> Following the discussions, and looking through the patch, I would say
> this patch is in pretty good shape (and quite impressive, too).
> 
> My vote would be to commit as is, unless something important comes up,
> and fix smaller problems and possible corner cases afterwards, if any
> exist.  However, I am not really deep into these aspects of the
> compiler, and I would still like to leave some time for others to
> comment if they think this is appropriate.
> 
> So, OK to commit in two days unless there are objections.
> 
> Thanks for the patch!
> 
> 	Thomas
> 


-- 
Andre Vehreschild * Email: vehre ad gmx dot de