[PING^2] [PATCH][5a/5] Postpone expanding va_arg until pass_stdarg

[Richard Biener]

On Tue, 9 Jun 2015, Tom de Vries wrote:

> On 09/06/15 13:03, Richard Biener wrote:
> > On Tue, 9 Jun 2015, Alan Lawrence wrote:
> > 
> > > Hmmm. One side effect of this is that the line number information
> > > available in
> > > the target hook gimplify_va_arg_expr, is now just the name of the
> > > containing
> > > function, rather than the specific use of va_arg. Is there some way to get
> > > this more precise location (e.g. gimple_location(stmt) in
> > > expand_ifn_va_arg_1,
> > > the only caller of said hook)? I don't really want to have to add an extra
> > > parameter to the target hook...
> > 
> > The x86 variant doesn't use any locations but if then the caller of
> > the target hook (expand_ifn_va_arg_1) should assign the IFNs location
> > to all statements expanded from it (it could set input_location to
> > that during the target hook call...)
> > 
> 
> That seems to work.
> 
> The scan-assembler-not test in the testcase in attached patch:
> - fails without the expand_ifn_va_arg_1 patch hunk, and
> - passes with that hunk.
> 
> I'll put it through bootstrap and reg-test on x86_64.
> 
> OK for trunk if that goes well?

Ok.

Thanks,
Richard.

> Thanks,
> - Tom
> 

-- 
Richard Biener <rguenther@suse.de>
SUSE LINUX GmbH, GF: Felix Imendoerffer, Jane Smithard, Dilip Upmanyu, Graham Norton, HRB 21284 (AG Nuernberg)