[PATCH] Refactor -Wmisleading-indentation API and extend coverage
Richard Sandiford
rdsandiford@googlemail.com
Mon Jun 8 19:49:00 GMT 2015
Patrick Palka <patrick@parcs.ath.cx> writes:
> On Mon, Jun 8, 2015 at 2:11 PM, David Malcolm <dmalcolm@redhat.com> wrote:
>>> void
>>> warn_for_misleading_indentation (const common_token_info &guard_tinfo,
>>> const common_token_info &body_tinfo,
>>> const common_token_info &next_tinfo);
>>
>> [Do we allow C++ reference syntax? I'm OK with it, and some of the
>> more "C++y" parts of codebase use it (templates), but I think Jeff
>> objected last time I tried to submit a patch with it :) ]
>
> I'm not sure. The use of references is not a big deal to me in this
> case at least. I will just pass three pointers instead.
FWIW: I thought const references were allowed for cases where the object
is logically being passed by value. We used that a lot in thw wide-int
code, where actually passing by value would be too slow and passing by
pointer too unnatural.
I thought it was out and in-out references that were the problem.
Thanks,
Richard
More information about the Gcc-patches
mailing list