[patch] Implement Ada support for DragonFly, improve it for FreeBSD

John Marino gnugcc@marino.st
Wed Jun 3 08:25:00 GMT 2015


On 6/3/2015 09:30, Arnaud Charlet wrote:
>>> Note 1)  All TOOL_TARGET_PAIRS in gcc/ada/gcc-interface/Makefile.in
>>> should be removed for most (if not all) platforms as they were moved to
>>> gnattools/configure and are now no-ops.  However, for this patch set I
>>> only removed them for FreeBSD.
>>
>> They are actually used if you configure with --disable-libada so should be
>> preserved.
> 
> Right.

Okay, so that means the Makefile.in patch needs changing in two ways:
1.  Don't remove TOOL_TARGET_PAIRS lines from two FreeBSD targets
2.  Add TOOL_TARGET_PAIRS line to new DragonFly target.

Is a new submission necessary or can this be handled by committer?
A new submission will take me a few days because I'm traveling ATM.



>>
>> This looks good to me modulo the TOOL_TARGET_PAIRS thing.  But ChangeLog
>> lines
>> must all start with a capital letter and end with a period.
>>
>> Please leave a couple of more days for Thomas or Arno to comment though.
> 
> My main question is: who will maintain these files after they are in
> (e.g. regularly test this configuration and post patches to fix any breakage)?

Well, both FreeBSD and DragonFly are officially supported platforms.
They both utilize FreeBSD ports which supports the last 5 releases and
the development release of GCC.  Additionally it features 2-3 versions
that specifically build GNAT.  So it is built continuously and breakage
will be found.

In all likelihood, I would be the first to discover the breakage and
also the most likely to submit the patch.  This covers all three targets
(both FreeBSD and the one DragonFly).

By the way, I am not aware of "official" build testing on the two
existing FreeBSD configurations, so in any case there is no regression.

Jonathan Wakely told me about gcc build farms -- I'd like to get a
continuous, automated DragonFly test build going as well.

John



More information about the Gcc-patches mailing list