[Patch] Small refactor on <regex> _State<>

Jonathan Wakely jwakely@redhat.com
Wed Jul 29 08:43:00 GMT 2015


On 28/07/15 16:19 +0100, Jonathan Wakely wrote:
>What I'm concerned about is assignment. You haven't defined an
>assignment operator. If there's an unwanted assignment we could get
>undefined behaviour. Please delete the assignment operator if it's not
>needed.

Apologies, you have a user-declared move constructor, so assignment is
already deleted. It wouldn't hurt to make that explicit though:

  _State& operator=(const _State&) = delete;

So it's just the alignment issue that I'm concerned about now.



More information about the Gcc-patches mailing list