[Patch, fortran] PR66929 fix iso_varying_string ICE

Mikael Morin mikael.morin@sfr.fr
Sat Jul 25 19:01:00 GMT 2015


Le 21/07/2015 23:10, Paul Richard Thomas a écrit :
> Hi Mikael,
>
> This looks fine to me - OK for trunk.
>
> Thanks for the patch
>
> Paul
>
> On 21 July 2015 at 14:53, Mikael Morin <mikael.morin@sfr.fr> wrote:
>> Hello,
>>
>> The fix for PR61831 committed recently [1] introduced/uncovered a NULLL
>> pointer dereference with iso_varying_string, because a generic symbol (which
>> has a NULL result) is used as procedure symbol, instead of the specific one.
>> Fixed by using esym if it's available.
>>
>> Regression-tested on x86_64-linux. OK for trunk?
>>
>> Mikael
>>
>> [1]: https://gcc.gnu.org/ml/gcc-patches/2015-06/msg01389.html
>>
>
Hello,

I would like to backport the patch.
As the bug was discovered with the patch [1] above, the test 
generic_30.f90 works on the branches, which don't have that patch.
Meanwhile, I have managed to find a test generic_31.f90 that exhibits a 
wrong code already on the branch, which justifies the backport.

Regression tested on the 5 branch, OK for 5 and 4.9?

Mikael


-------------- next part --------------
2015-07-25  Mikael Morin  <mikael@gcc.gnu.org>

	PR fortran/66929
	* trans-array.c (gfc_get_proc_ifc_for_expr): Use esym as procedure
	symbol if available.

2015-07-25  Mikael Morin  <mikael@gcc.gnu.org>

	PR fortran/66929
	* gfortran.dg/generic_30.f90: New.
	* gfortran.dg/generic_31.f90: New.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: pr66929_1.diff
Type: text/x-patch
Size: 619 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150725/720345ee/attachment.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: generic_30.f90
Type: text/x-fortran
Size: 1360 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150725/720345ee/attachment-0001.bin>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: generic_31.f90
Type: text/x-fortran
Size: 794 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150725/720345ee/attachment-0002.bin>


More information about the Gcc-patches mailing list