[gomp4] remove kernel-specific launch
Tom de Vries
Tom_deVries@mentor.com
Mon Jul 20 12:08:00 GMT 2015
On 19/07/15 23:08, Nathan Sidwell wrote:
> On 07/19/15 16:30, Thomas Schwinge wrote:
>
>> gcc/tree-parloops.c: /* Remove GOACC_kernels. */
>> libgomp/libgomp.map: GOACC_kernels;
>> libgomp/libgomp_g.h:extern void GOACC_kernels (int, void (*)
>> (void *), size_t,
>
> I fixed all byt the parloops comment. That comment didn't really make
> sense to me -- it seems to be doing something with the pragma not the
> call. Perhaps Tom could correct/clarify it?
>
Committed as attached.
>> Does it make sense then to rename GOACC_kernels_internal to
>> GOACC_kernels?
>
> I agree with Tom. But perhaps it should be an internal fn? IIUC those
> are for pseudo-funcs that should be converted to something else before
> the end of compilation.
Turning it into an internal fn will make it harder to convert a
GOACC_kernels_internal call into a GOACC_parallel call, which we're
doing here in omp-low.c:
...
tree fndecl = builtin_decl_explicit (BUILT_IN_GOACC_PARALLEL);
gimple_call_set_fndecl (call, fndecl);
gimple_call_set_fntype (call, TREE_TYPE (fndecl));
gimple_call_reset_alias_info (call);
...
Thanks,
- Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: 0001-Update-create_parallel_loop-for-remove-GOACC_kernels.patch
Type: text/x-patch
Size: 2046 bytes
Desc: not available
URL: <http://gcc.gnu.org/pipermail/gcc-patches/attachments/20150720/2683ddc0/attachment.bin>
More information about the Gcc-patches
mailing list