[PATCH] Remove duplicate graphite statistics printers

Jeff Law law@redhat.com
Thu Jul 9 17:49:00 GMT 2015


On 07/09/2015 11:48 AM, Bernhard Reutner-Fischer wrote:
> On July 9, 2015 6:48:39 PM GMT+02:00, Jeff Law <law@redhat.com> wrote:
>> On 07/09/2015 10:30 AM, Bernhard Reutner-Fischer wrote:
>>>
>>> Thanks,
>>>
>>> gcc/ChangeLog
>>>
>>> 2015-07-09  Bernhard Reutner-Fischer  <aldot@gcc.gnu.org>
>>>
>>> 	* graphite.h: New file.
>>> 	(print_graphite_statistics): Extern declaration.
>>> 	* graphite-scop-detection.c (print_graphite_scop_statistics,
>>> 	print_graphite_statistics): Remove.
>>> 	* graphite.c (print_graphite_statistics): Make public and add
>>> 	PREFIX parameter. Adjust callers.
>>> 	(print_graphite_scop_statistics): Add PREFIX parameter.
>>>
>>> Signed-off-by: Bernhard Reutner-Fischer <rep.dot.nop@gmail.com>
>>> ---
>>> -/* Print statistics for SCOPS to FILE.  */
>>> +/* Print statistics for SCOPS to FILE. Prefix statistic headers with
>> PREFIX.  */
>> Nit.  Two spaces after a period, even in comments.
>
> Done.
>
> I wasn't sure where to put the prototype, maybe a graphite.h for just that (ATM) is not warranted?
> Maybe an extern decl in graphite-scop-detection.c would be sufficient?
But it's more generic than that.  I also wouldn't be surprised if we 
found other things that belonged in graphite.h.

jeff



More information about the Gcc-patches mailing list