[PATCH] MIPS: Update stack-1.c testcase to match micromips jraddiusp instruction.

[Moore, Catherine]

> -----Original Message-----
> From: Andrew Bennett [mailto:Andrew.Bennett@imgtec.com]
> Sent: Tuesday, July 07, 2015 12:14 PM
> To: Moore, Catherine; Matthew Fortune; gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH] MIPS: Update stack-1.c testcase to match micromips
> jraddiusp instruction.
> 
> > > I'm not sure this is the right approach here. If we get a jraddiusp
> > > then the problem that the test is trying to cover can't possibly happen
> anyway.
> > > (The test is checking if a load and final stack adjustment are ever
> > > re-
> > ordered
> > > from what I can see.)
> > >
> > > I'd just mark the test as NOCOMPRESSION instead of just NOMIPS16 and
> > > update the comment to say that it is avoiding SAVE, RESTORE and
> > > JRADDIUSP.
> > >
> >
> > Another approach would be to add the micromips testcase variant and
> > skip the test if code-quality (ie. -O0).
> > Catherine
> 
> I agree with Matthew here.  The testcase already comments that it is
> preventing the use of the MIPS16 save and restore instructions, so it makes
> sense to prevent jraddiusp as well.
> 
> The updated patch and ChangeLog is below.
> 
> Ok to commit?
> 
> 
> 
> testsuite/
> 	* gcc.target/mips/stack-1.c: Do not build the testcase for micromips.
> 
> 
Yes, this is OK.