[Patch, fortran] PR52846 - [F2008] Support submodules

Paul Richard Thomas paul.richard.thomas@gmail.com
Thu Jul 2 20:45:00 GMT 2015


Dear All,

Committed as revision 225354.

Compared with the submitted version, I have added another test -
submodule_7.f90. This is a slightly tweaked version of the example in
the F2008 standard. In order to get it to compile, the error produced
by the main program's interface block was suppressed by excluding
module procedures from the error in interface.c. Otherwise, the
compiler complains that module procedures are not module procedures.

Thanks to Damian, Reinhold, Salvatore and FX for help, comments and advice.

I'll get on and sort out the business with private symbols now.

Cheers

Paul


On 30 June 2015 at 15:51, FX <fxcoudert@gmail.com> wrote:
> Hi Paul,
>
> I don’t feel confident enough in many parts of the code (including the module part) to formally review it, but from what I’ve read it seemed rather logical and well-commented. If it regtests fine, I think your plan (especially at the current GCC stage) of committing this week is sound.
>
> One question I had is: does this change the .mod file format in any case? I don’t think, cause you don’t seem to bump the version number, but have you checked on specific cases (like, the mega cp2k example) that the patch indeed does not change existing module files (the ones that do not use submodules)?
>
> Cheers, and thanks for this patch!
>
> FX
>



-- 
Outside of a dog, a book is a man's best friend. Inside of a dog it's
too dark to read.

Groucho Marx



More information about the Gcc-patches mailing list