[Patch, fortran] Cosmetics: Dup. code removal, indent fix, typo fix.

Jerry DeLisle jvdelisle@charter.net
Sat Jan 31 21:55:00 GMT 2015


On 01/30/2015 04:10 AM, Andre Vehreschild wrote:
> Hi all,
>
> I fear this fix is not so obvious in one location, I therefore ask for a
> review. The attached patch fixes:
>
> - a duplicate code fragment (possibly due to merged twice),
> - the indentation in the trans-expr.c block (in my first patch), and
> - a typo on the datatype-size to create for the charlen.
>
> The length of a char-array is stored as a 4-byte BT_INTEGER. Due to a typo a
> 1-byte BT_INTEGER was requested. The patch fixes this. I know this patch mixes
> several trivial issues. Should I do separate patches for each of them, or what
> is the most desirable method?
>

Cosmetic things are OK to throw in the mix as long as you have the Changelog. 
Duplicate code removal is just about as obvious as one can get. No need for 
separate patches.

> Bootstraps and regtests ok on x86_64-linux-gnu/FC20.
>

I have learned the hard way that if you forget the testing even on trivial 
things it can byte you.  OK to commit!  Thanks.



More information about the Gcc-patches mailing list