PR lto/64837: lto plugin doesn't call ld_plugin_release_input_file
Cary Coutant
ccoutant@google.com
Wed Jan 28 20:17:00 GMT 2015
>>>This patch makes claim_file_handler to call release_input_file after it
>>>finishes processing input file. OK for trunk?
>>
>> OK. How did you test this?
>
> I did normal bootstrap and "make check" on Linux/x86-64.
> I also run ld.bfd and ld.gold by hand to verify that release_input_file
> is called.
But release_input_file is only supposed to be used after calling
get_input_file from the all_symbols_read handler. It's not needed in
the claim_file handler. If gold isn't freeing the file descriptor
properly in that case, it's a bug entirely within gold (I think). I'm
looking at it.
-cary
More information about the Gcc-patches
mailing list